Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3578 Condition replaces the use of the Object monitor methods #253

Closed
wants to merge 1 commit into from

Conversation

hit-lacus
Copy link
Member

@asfgit
Copy link

asfgit commented Sep 25, 2018

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link

asfgit commented Sep 25, 2018

Can one of the admins verify this patch?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3653

  • 0 of 8 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 23.125%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/util/MemoryBudgetController.java 0 8 0.0%
Totals Coverage Status
Change from base Build 3650: 0.004%
Covered Lines: 16159
Relevant Lines: 69876

💛 - Coveralls

@hit-lacus
Copy link
Member Author

hit-lacus commented Sep 26, 2018

Admin, please do not merge this commit, I will recheck my commit.

@hit-lacus
Copy link
Member Author

if (delta < 0) {
     synchronized (lock) {
        lock.notifyAll();
    }
}

This code above seems violates good practice, but it's just a trick.So it is no need to repair it.

oracle locksync doc
Chinese Javadoc
Do not synchronize on the intrinsic locks of high-level concurrency objects

@hit-lacus hit-lacus closed this Sep 26, 2018
@hit-lacus hit-lacus deleted the KYLIN-3578 branch September 27, 2018 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants