Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3587 Including tableID in IllegalStateException messages #256

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

ZhouYC627
Copy link

@asfgit
Copy link

asfgit commented Sep 25, 2018

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link

asfgit commented Sep 25, 2018

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #256 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #256      +/-   ##
============================================
+ Coverage     21.11%   21.11%   +<.01%     
+ Complexity     4404     4403       -1     
============================================
  Files          1087     1087              
  Lines         69878    69878              
  Branches      10103    10103              
============================================
+ Hits          14756    14758       +2     
+ Misses        53723    53721       -2     
  Partials       1399     1399
Impacted Files Coverage Δ Complexity Δ
.../apache/kylin/metadata/project/ProjectManager.java 10.52% <0%> (ø) 7 <0> (ø) ⬇️
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 66.15% <0%> (+2.3%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34fd447...4c2ddde. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3656

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 23.125%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-metadata/src/main/java/org/apache/kylin/metadata/project/ProjectManager.java 0 3 0.0%
Totals Coverage Status
Change from base Build 3650: 0.003%
Covered Lines: 16159
Relevant Lines: 69878

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit c8610e2 into apache:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants