Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fix KYLIN-3595 #257

Merged
merged 1 commit into from Sep 26, 2018
Merged

Update to fix KYLIN-3595 #257

merged 1 commit into from Sep 26, 2018

Conversation

rtjarvis
Copy link

No description provided.

@asfgit
Copy link

asfgit commented Sep 25, 2018

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #257 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #257      +/-   ##
============================================
- Coverage     21.11%   21.11%   -0.01%     
  Complexity     4404     4404              
============================================
  Files          1087     1087              
  Lines         69878    69878              
  Branches      10103    10103              
============================================
- Hits          14756    14752       -4     
- Misses        53723    53725       +2     
- Partials       1399     1401       +2
Impacted Files Coverage Δ Complexity Δ
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.3% <0%> (-0.92%) 7% <0%> (ø)
...lin/dict/lookup/cache/RocksDBLookupTableCache.java 76.16% <0%> (-0.52%) 27% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34fd447...5b7da0b. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3657

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 23.119%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 5 77.81%
Totals Coverage Status
Change from base Build 3650: -0.003%
Covered Lines: 16155
Relevant Lines: 69878

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit cd8c375 into apache:master Sep 26, 2018
@shaofengshi
Copy link
Contributor

Merged in master and 2.5.x branch, thank you, Richard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants