Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3605 upgrade hadoop-common and zookeeper version to fix securit… #276

Closed
wants to merge 2 commits into from

Conversation

shaofengshi
Copy link
Contributor

…y issues

@asfgit
Copy link

asfgit commented Sep 29, 2018

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link

asfgit commented Sep 29, 2018

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Sep 30, 2018

Codecov Report

Merging #276 into master will increase coverage by 0.13%.
The diff coverage is 80.98%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #276      +/-   ##
============================================
+ Coverage     21.14%   21.28%   +0.13%     
- Complexity     4405     4435      +30     
============================================
  Files          1086     1087       +1     
  Lines         69801    69976     +175     
  Branches      10110    10126      +16     
============================================
+ Hits          14760    14891     +131     
- Misses        53641    53681      +40     
- Partials       1400     1404       +4
Impacted Files Coverage Δ Complexity Δ
...ylin/common/metrics/metrics2/Metrics2Reporter.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ommon/metrics/metrics2/HadoopMetrics2Reporter.java 80.98% <80.98%> (ø) 30 <30> (?)
...lin/dict/lookup/cache/RocksDBLookupTableCache.java 76.16% <0%> (-0.52%) 27% <0%> (ø)
...ache/kylin/cube/inmemcubing/DoggedCubeBuilder.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
.../routing/rules/RemoveBlackoutRealizationsRule.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...pache/kylin/cube/inmemcubing/InMemCubeBuilder.java 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db0330...8bf7b3d. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3724

  • 135 of 163 (82.82%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 23.289%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/metrics/metrics2/HadoopMetrics2Reporter.java 135 163 82.82%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/InMemCubeBuilder.java 5 0.0%
query/src/main/java/org/apache/kylin/query/routing/rules/RemoveBlackoutRealizationsRule.java 6 0.0%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/DoggedCubeBuilder.java 13 0.0%
Totals Coverage Status
Change from base Build 3723: 0.1%
Covered Lines: 16297
Relevant Lines: 69976

💛 - Coveralls

@shaofengshi
Copy link
Contributor Author

Merged.

@shaofengshi shaofengshi deleted the KYLIN-3605 branch September 30, 2018 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants