Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3647 Fix inconsistent states of job and its sub-task #311

Merged
merged 1 commit into from
Oct 25, 2018

Conversation

hit-lacus
Copy link
Member

@hit-lacus hit-lacus commented Oct 25, 2018

@asfgit
Copy link

asfgit commented Oct 25, 2018

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@21bc42d). Click here to learn what that means.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #311   +/-   ##
=========================================
  Coverage          ?   21.29%           
  Complexity        ?     4445           
=========================================
  Files             ?     1090           
  Lines             ?    70014           
  Branches          ?    10103           
=========================================
  Hits              ?    14908           
  Misses            ?    53702           
  Partials          ?     1404
Impacted Files Coverage Δ Complexity Δ
...he/kylin/job/impl/threadpool/DefaultScheduler.java 66.66% <0%> (ø) 9 <0> (?)
...apache/kylin/job/execution/AbstractExecutable.java 51.4% <0%> (ø) 48 <0> (?)
.../kylin/job/execution/DefaultChainedExecutable.java 66.66% <100%> (ø) 22 <0> (?)
.../apache/kylin/job/execution/ExecutableManager.java 33.62% <28.57%> (ø) 34 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21bc42d...31649b7. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 0f0346b into apache:master Oct 25, 2018
@hit-lacus hit-lacus deleted the merge_ke branch November 14, 2018 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants