Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3656 Improve HLLCounter performance #345

Merged
merged 1 commit into from Nov 15, 2018

Conversation

hit-lacus
Copy link
Member

The current HLLCounter implementation has some room to improve performance, as we find in our product environment. Improvement related to getCountEstimate of HLLCounter and constructor of HLLCounter.

  • Create HLLCounter from another HLLCounter, we can copy register(using System.arraycopy) instead of merge. (Constructor of HLLCounter)
  • Precompute harmonic mean in the HLLCSnapshot to avoid doing this on the fly. (getCountEstimate of HLLCounter)

UnitTest has add cost duration compare.

@asfgit
Copy link

asfgit commented Nov 15, 2018

Can one of the admins verify this patch?

@hit-lacus
Copy link
Member Author

Local CI pass.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3850

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 23.643%

Totals Coverage Status
Change from base Build 3845: 0.02%
Covered Lines: 16835
Relevant Lines: 71206

💛 - Coveralls

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 889dc50 into apache:master Nov 15, 2018
@hit-lacus hit-lacus deleted the hll_impro branch November 15, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants