Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3597 fix sonar issues #379

Merged
merged 2 commits into from Dec 10, 2018
Merged

Conversation

whuwb
Copy link

@whuwb whuwb commented Dec 10, 2018

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Kylin 2.6.0-SNAPSHOT:
[INFO]
[INFO] Apache Kylin ....................................... SUCCESS [ 6.897 s]
[INFO] Apache Kylin - Core Common ......................... SUCCESS [ 14.739 s]
[INFO] Apache Kylin - Core Metadata ....................... SUCCESS [ 58.231 s]
[INFO] Apache Kylin - Core Dictionary ..................... SUCCESS [05:17 min]
[INFO] Apache Kylin - Core Cube ........................... SUCCESS [01:21 min]
[INFO] Apache Kylin - Core Metrics ........................ SUCCESS [ 1.472 s]
[INFO] Apache Kylin - Core Job ............................ SUCCESS [ 43.913 s]
[INFO] Apache Kylin - Core Storage ........................ SUCCESS [ 8.012 s]
[INFO] Apache Kylin - MapReduce Engine .................... SUCCESS [ 19.776 s]
[INFO] Apache Kylin - Spark Engine ........................ SUCCESS [ 7.607 s]
[INFO] Apache Kylin - Hive Source ......................... SUCCESS [ 7.070 s]
[INFO] Apache Kylin - DataSource SDK ...................... SUCCESS [ 12.198 s]
[INFO] Apache Kylin - Jdbc Source ......................... SUCCESS [ 20.597 s]
[INFO] Apache Kylin - Kafka Source ........................ SUCCESS [ 5.457 s]
[INFO] Apache Kylin - Cache ............................... SUCCESS [ 9.464 s]
[INFO] Apache Kylin - HBase Storage ....................... SUCCESS [ 17.873 s]
[INFO] Apache Kylin - Query ............................... SUCCESS [ 13.782 s]
[INFO] Apache Kylin - Metrics Reporter Hive ............... SUCCESS [ 0.985 s]
[INFO] Apache Kylin - Metrics Reporter Kafka .............. SUCCESS [ 0.869 s]
[INFO] Apache Kylin - REST Server Base .................... SUCCESS [ 28.272 s]
[INFO] Apache Kylin - REST Server ......................... SUCCESS [01:35 min]
[INFO] Apache Kylin - JDBC Driver ......................... SUCCESS [ 8.622 s]
[INFO] Apache Kylin - Assembly ............................ SUCCESS [ 16.291 s]
[INFO] Apache Kylin - Tool ................................ SUCCESS [ 12.324 s]
[INFO] Apache Kylin - Tool Assembly ....................... SUCCESS [ 3.907 s]
[INFO] Apache Kylin - Integration Test .................... SUCCESS [ 02:38 h]
[INFO] Apache Kylin - Tomcat Extension .................... SUCCESS [ 2.266 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:52 h
[INFO] Finished at: 2018-12-07T19:22:25Z
[INFO] ------------------------------------------------------------------------

@asfgit
Copy link

asfgit commented Dec 10, 2018

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@684f21c). Click here to learn what that means.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #379   +/-   ##
=========================================
  Coverage          ?   23.64%           
  Complexity        ?     4882           
=========================================
  Files             ?     1134           
  Lines             ?    68641           
  Branches          ?     9750           
=========================================
  Hits              ?    16228           
  Misses            ?    50826           
  Partials          ?     1587
Impacted Files Coverage Δ Complexity Δ
...ache/kylin/common/BackwardCompatibilityConfig.java 41.81% <0%> (ø) 15 <0> (?)
...main/java/org/apache/kylin/common/KylinConfig.java 36.17% <25%> (ø) 23 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 684f21c...5109f65. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit 497cdf0 into apache:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants