Kylin 3597 fix sonar issues #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
shaofengshi
reviewed
Dec 22, 2018
| CachedRowSet crs = new FixedCachedRowSetImpl(); | ||
| crs.populate(resultSet); | ||
| return crs; | ||
| try (CachedRowSet crs = new FixedCachedRowSetImpl()) { |
There was a problem hiding this comment.
I'm afraid this will lead to error.
shaofengshi
reviewed
Dec 22, 2018
| logger.info("Wild estimate of base aggr cache is " + mbEstimateBaseAggrCache + " MB"); | ||
| int mbEstimateBaseAggrCache = (int) (aggregationScanner.getEstimateSizeOfAggrCache() | ||
| / MemoryBudgetController.ONE_MB); | ||
| logger.info("Wild estimate of base aggr cache is " + mbEstimateBaseAggrCache + " MB"); |
There was a problem hiding this comment.
We can use the "{}" to format the log output.
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
============================================
- Coverage 24.39% 24.38% -0.01%
+ Complexity 4935 4934 -1
============================================
Files 1143 1143
Lines 69259 69259
Branches 9859 9859
============================================
- Hits 16897 16892 -5
- Misses 50665 50668 +3
- Partials 1697 1699 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.