Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3776 Float type in MySQL not properly converted to HIVE Double … #438

Merged
merged 1 commit into from Jan 21, 2019

Conversation

hit-lacus
Copy link
Member

…Type

@asfgit
Copy link

asfgit commented Jan 21, 2019

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link

asfgit commented Jan 21, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@4a025fe). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #438   +/-   ##
=========================================
  Coverage          ?   24.37%           
  Complexity        ?     4941           
=========================================
  Files             ?     1143           
  Lines             ?    69359           
  Branches          ?     9888           
=========================================
  Hits              ?    16906           
  Misses            ?    50746           
  Partials          ?     1707
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/kylin/job/JoinedFlatTable.java 0% <0%> (ø) 0 <0> (?)
...ain/java/org/apache/kylin/source/jdbc/SqlUtil.java 12.32% <0%> (ø) 9 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a025fe...8b01ca0. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit e413a81 into apache:master Jan 21, 2019
@hit-lacus hit-lacus deleted the KYLIN-3776-1 branch August 15, 2019 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants