Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3262 add a copy phase for copying jacoco related jars to dev-support folder #519

Merged
merged 1 commit into from Mar 15, 2019

Conversation

kyotoYaho
Copy link
Contributor

No description provided.

@asfgit
Copy link

asfgit commented Mar 15, 2019

Can one of the admins verify this patch?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4238

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 26.913%

Files with Coverage Reduction New Missed Lines %
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 4 78.12%
Totals Coverage Status
Change from base Build 4236: 0.003%
Covered Lines: 18944
Relevant Lines: 70390

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d23d2bd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #519   +/-   ##
=========================================
  Coverage          ?   24.44%           
  Complexity        ?     5023           
=========================================
  Files             ?     1160           
  Lines             ?    70390           
  Branches          ?    10013           
=========================================
  Hits              ?    17204           
  Misses            ?    51450           
  Partials          ?     1736

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23d2bd...263eb98. Read the comment docs.

Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@shaofengshi shaofengshi merged commit 7b88a99 into apache:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants