Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3918: Add project name in cube and job pages #560

Merged
merged 1 commit into from Apr 11, 2019

Conversation

lshmouse
Copy link

@asfgit
Copy link

asfgit commented Mar 27, 2019

Can one of the admins verify this patch?

1 similar comment
@asfgit
Copy link

asfgit commented Mar 27, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@59378ef). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #560   +/-   ##
=========================================
  Coverage          ?   25.36%           
  Complexity        ?     5795           
=========================================
  Files             ?     1371           
  Lines             ?    81109           
  Branches          ?    11369           
=========================================
  Hits              ?    20575           
  Misses            ?    58523           
  Partials          ?     2011
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/apache/kylin/job/JobInstance.java 0% <0%> (ø) 0 <0> (?)
...pache/kylin/engine/mr/common/JobInfoConverter.java 15.74% <0%> (ø) 7 <0> (?)
...java/org/apache/kylin/rest/service/JobService.java 0% <0%> (ø) 0 <0> (?)
...va/org/apache/kylin/tool/JobInstanceExtractor.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59378ef...25dce54. Read the comment docs.

@nichunen
Copy link

nichunen commented Apr 9, 2019

@lshmouse Hi, why should project name should be shown on each job even if the job name can be seen on the project drop down list?

@nichunen nichunen self-requested a review April 9, 2019 15:27
Copy link
Contributor

@shaofengshi shaofengshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaofengshi shaofengshi merged commit ddc51f3 into apache:master Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants