-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KYLIN-4001 Allow user-specified time format using real-time #624
Conversation
Can one of the admins verify this patch? |
I am really sorry, this is the first time I submitted the source code to the open source community. I skipped checkstyle, and now this version has been checked by checkstyle.xml. |
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
============================================
- Coverage 25.67% 25.67% -0.01%
- Complexity 5957 5961 +4
============================================
Files 1379 1382 +3
Lines 82097 82144 +47
Branches 11507 11509 +2
============================================
+ Hits 21081 21090 +9
- Misses 58978 59012 +34
- Partials 2038 2042 +4
Continue to review full report at Codecov.
|
Hi, could you please update your commit? @GuoNingNing
Thank you so much~ |
} catch (Exception e) { | ||
throw new IllegalStateException("Invalid StreamingConfig, tsParser " + tsParser + ", tsPattern " + parserInfo.getTsPattern() + ".", e); | ||
} | ||
}else{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code not formated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you merge this commit with the previous backend commit
could you merge all commits into 2 commits? |
Allow user-specified time format using real-time
I found that real-time only supports millisecond timestamp, does not support second timestamp and Date type like '2019-01-01 11:11:11'.
I add a LongTimeParser and a DateTimeParser and page configuration
You can configure tsParser, tsPattern on the page that creates the streaming table.
for date :
{ "timestamp":"2019-04-29 11:11:11","gmv":1.1 }
tsParser=org.apache.kylin.stream.source.kafka.DateTimeParser
tsPattern=yyyy-MM-dd HH:mm:ss
for second :
{ "timestamp":"1556618887","gmv":1.1 }
tsParser=org.apache.kylin.stream.source.kafka.LongTimeParser
tsPattern=S
for millisecond :
{ "timestamp":"1556618887000","gmv":1.1 }
tsParser=org.apache.kylin.stream.source.kafka.LongTimeParser
tsPattern=MS