Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3958 MrHive-Dict support build by livy #648

Merged
merged 2 commits into from
May 23, 2019
Merged

Conversation

hit-lacus
Copy link
Member

No description provided.

@asfgit
Copy link

asfgit commented May 19, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #648 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #648      +/-   ##
===========================================
+ Coverage      25.8%   25.8%   +<.01%     
  Complexity     6009    6009              
===========================================
  Files          1382    1382              
  Lines         82145   82155      +10     
  Branches      11509   11511       +2     
===========================================
+ Hits          21196   21199       +3     
- Misses        58902   58910       +8     
+ Partials       2047    2046       -1
Impacted Files Coverage Δ Complexity Δ
...urce/hive/RedistributeFlatHiveTableByLivyStep.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...apache/kylin/source/hive/CreateMrHiveDictStep.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/apache/kylin/common/livy/LivyRestClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...lin/source/hive/CreateFlatHiveTableByLivyStep.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/org/apache/kylin/common/util/HiveCmdBuilder.java 81.08% <0%> (-1.12%) 12 <0> (ø)
...a/org/apache/kylin/source/hive/MRHiveDictUtil.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 70.21% <0%> (+0.91%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7b242...d1a788e. Read the comment docs.

@hit-lacus
Copy link
Member Author

Regression test and manual test passed.

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit 47431ba into apache:master May 23, 2019
@hit-lacus hit-lacus deleted the 3958 branch August 16, 2019 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants