Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-3999, make kylin.query.enable-dynamic-column default true #698

Merged
merged 1 commit into from Jun 19, 2019

Conversation

yuexingri
Copy link

rt

@asfgit
Copy link

asfgit commented Jun 19, 2019

Can one of the admins verify this patch?

3 similar comments
@asfgit
Copy link

asfgit commented Jun 19, 2019

Can one of the admins verify this patch?

@asfgit
Copy link

asfgit commented Jun 19, 2019

Can one of the admins verify this patch?

@asfgit
Copy link

asfgit commented Jun 19, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #698 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #698      +/-   ##
============================================
- Coverage     25.72%   25.71%   -0.02%     
+ Complexity     6011     6010       -1     
============================================
  Files          1385     1385              
  Lines         82401    82401              
  Branches      11553    11553              
============================================
- Hits          21201    21188      -13     
- Misses        59156    59164       +8     
- Partials       2044     2049       +5
Impacted Files Coverage Δ Complexity Δ
.../java/org/apache/kylin/common/KylinConfigBase.java 12.94% <0%> (ø) 42 <0> (ø) ⬇️
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 66.56% <0%> (-3.65%) 7% <0%> (ø)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 66.15% <0%> (+2.3%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe98c9...fb97bbf. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4628

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 28.204%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 7 76.29%
Totals Coverage Status
Change from base Build 4626: -0.01%
Covered Lines: 23240
Relevant Lines: 82401

💛 - Coveralls

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit 5b1d0a5 into apache:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants