Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert KYLIN-4039 because it break IT #730

Merged
merged 1 commit into from Jul 4, 2019

Conversation

hit-lacus
Copy link
Member

This reverts commit 8712a87.

… catching interrupt exception"

This reverts commit 8712a87.
@asfgit
Copy link

asfgit commented Jul 4, 2019

Can one of the admins verify this patch?

@hit-lacus
Copy link
Member Author

This commit make IT failed because "ITZookeeperDistributedLockTest.testWatch:183 expected:<0> but was:<4>", after revert, IT succeed.

@codecov-io
Copy link

Codecov Report

Merging #730 into master will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #730      +/-   ##
============================================
- Coverage     25.78%   25.71%   -0.08%     
+ Complexity     6038     6016      -22     
============================================
  Files          1392     1386       -6     
  Lines         82808    82708     -100     
  Branches      11603    11599       -4     
============================================
- Hits          21355    21268      -87     
+ Misses        59399    59381      -18     
- Partials       2054     2059       +5
Impacted Files Coverage Δ Complexity Δ
...n/job/lock/zookeeper/ZookeeperDistributedLock.java 0% <0%> (-54.68%) 0 <0> (-18)
...che/kylin/stream/core/storage/CheckPointStore.java 63.63% <0%> (-3.04%) 21% <0%> (-1%)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (-0.61%) 7% <0%> (ø)
...eam/core/storage/columnar/DataSegmentFragment.java 59.01% <0%> (+1.63%) 18% <0%> (+1%) ⬆️
...ream/core/storage/columnar/ColumnarStoreCache.java 54.65% <0%> (+3.48%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b1927c...d311b49. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4694

  • 0 of 26 (0.0%) changed or added relevant lines in 1 file are covered.
  • 36 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 28.208%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/ZookeeperDistributedLock.java 0 26 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java 2 73.74%
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/ZookeeperDistributedLock.java 33 0.0%
Totals Coverage Status
Change from base Build 4690: -0.06%
Covered Lines: 23330
Relevant Lines: 82708

💛 - Coveralls

@hit-lacus hit-lacus changed the title Revert KYLIN-4039 because it break CI Revert KYLIN-4039 because it break IT Jul 4, 2019
Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit 96ba0c6 into apache:master Jul 4, 2019
@hit-lacus hit-lacus deleted the revert-4039 branch August 16, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants