Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4039, fix ZK distributed lock may not release lock when catchin… #734

Merged
merged 2 commits into from Jul 28, 2019

Conversation

ZhengshuaiPENG
Copy link

…g interrupt exception

@asfgit
Copy link

asfgit commented Jul 5, 2019

Can one of the admins verify this patch?

@coveralls
Copy link

coveralls commented Jul 5, 2019

Pull Request Test Coverage Report for Build 4779

  • 49 of 123 (39.84%) changed or added relevant lines in 7 files are covered.
  • 1142 unchanged lines in 33 files lost coverage.
  • Overall coverage increased (+0.05%) to 28.242%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-job/src/main/java/org/apache/kylin/job/util/ThrowableUtils.java 0 5 0.0%
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/exception/ZkPeekLockInterruptException.java 2 10 20.0%
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/exception/ZkReleaseLockException.java 2 10 20.0%
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/exception/ZkReleaseLockInterruptException.java 2 10 20.0%
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/exception/ZkAcquireLockException.java 0 10 0.0%
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/exception/ZkPeekLockException.java 0 10 0.0%
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/ZookeeperDistributedLock.java 43 68 63.24%
Files with Coverage Reduction New Missed Lines %
stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/GeneralColumnDataReader.java 1 92.11%
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/StubReservoir.java 2 0.0%
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 3 78.42%
core-job/src/main/java/org/apache/kylin/job/lock/zookeeper/ZookeeperDistributedLock.java 3 56.83%
core-dictionary/src/main/java/org/apache/kylin/dict/TrieDictionaryForestBuilder.java 3 92.59%
core-metrics/src/main/java/org/apache/kylin/metrics/lib/impl/AbstractActiveReservoir.java 3 0.0%
core-metrics/src/main/java/org/apache/kylin/metrics/lib/ActiveReservoirReporter.java 6 0.0%
source-kafka/src/main/java/org/apache/kylin/source/kafka/TimedJsonStreamParser.java 8 90.11%
core-cube/src/main/java/org/apache/kylin/cube/model/CubeDesc.java 11 70.32%
core-metrics/src/main/java/org/apache/kylin/metrics/property/QueryRPCPropertyEnum.java 13 0.0%
Totals Coverage Status
Change from base Build 4701: 0.05%
Covered Lines: 23432
Relevant Lines: 82968

💛 - Coveralls

@codecov-io
Copy link

Codecov Report

Merging #734 into master will increase coverage by 0.03%.
The diff coverage is 39.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #734      +/-   ##
============================================
+ Coverage     25.72%   25.76%   +0.03%     
- Complexity     6019     6041      +22     
============================================
  Files          1386     1393       +7     
  Lines         82708    82968     +260     
  Branches      11599    11602       +3     
============================================
+ Hits          21280    21373      +93     
- Misses        59379    59539     +160     
- Partials       2049     2056       +7
Impacted Files Coverage Δ Complexity Δ
...java/org/apache/kylin/job/util/ThrowableUtils.java 0% <0%> (ø) 0 <0> (?)
...ck/zookeeper/exception/ZkAcquireLockException.java 0% <0%> (ø) 0 <0> (?)
.../lock/zookeeper/exception/ZkPeekLockException.java 0% <0%> (ø) 0 <0> (?)
...keeper/exception/ZkPeekLockInterruptException.java 20% <20%> (ø) 1 <1> (?)
...per/exception/ZkReleaseLockInterruptException.java 20% <20%> (ø) 1 <1> (?)
...ck/zookeeper/exception/ZkReleaseLockException.java 20% <20%> (ø) 1 <1> (?)
...n/job/lock/zookeeper/ZookeeperDistributedLock.java 54.67% <61.76%> (+54.67%) 18 <5> (+18) ⬆️
...he/kylin/stream/core/metrics/StreamingMetrics.java 23.07% <0%> (-43.59%) 4% <0%> (ø)
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...core/storage/columnar/GeneralColumnDataReader.java 89.47% <0%> (-5.27%) 6% <0%> (-1%)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ba0c6...3f3172e. Read the comment docs.

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to me

@nichunen nichunen merged commit 1d56aee into apache:master Jul 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants