Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4092: Support setting seperate jvm params for kylin backgroud tools #753

Merged
merged 1 commit into from Jul 30, 2019

Conversation

lshmouse
Copy link

@codecov-io
Copy link

Codecov Report

Merging #753 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #753      +/-   ##
============================================
- Coverage     25.72%   25.71%   -0.01%     
+ Complexity     6022     6021       -1     
============================================
  Files          1387     1387              
  Lines         82770    82770              
  Branches      11588    11588              
============================================
- Hits          21290    21283       -7     
- Misses        59435    59440       +5     
- Partials       2045     2047       +2
Impacted Files Coverage Δ Complexity Δ
...org/apache/kylin/rest/util/QueryRequestLimits.java 35.71% <0%> (-4.77%) 5% <0%> (-1%)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db184be...e59dca3. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4740

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.002%) to 28.19%

Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java 2 68.46%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
Totals Coverage Status
Change from base Build 4733: -0.002%
Covered Lines: 23333
Relevant Lines: 82770

💛 - Coveralls

@nichunen
Copy link

LGTM

@nichunen nichunen merged commit 38737f1 into apache:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants