KYLIN-4113 Remove the surplus allCubes field #780
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #780 +/- ##
============================================
- Coverage 25.76% 25.76% -0.01%
+ Complexity 6048 6047 -1
============================================
Files 1393 1393
Lines 82969 82969
Branches 11605 11605
============================================
- Hits 21380 21379 -1
- Misses 59536 59537 +1
Partials 2053 2053
Continue to review full report at Codecov.
|
ClausClaus
changed the title
There was a problem hiding this comment.
@clambertus There seems to be some conflicts, you'd better resolve them before resubmit your changes
| @@ -260,7 +244,7 @@ KylinApp.controller('CubeSchemaCtrl', function ($scope, QueryService, UserServic | |||
|
|
|||
| }); | |||
|
|
|||
| $scope.checkCubeForm = function(stepIndex){ | |||
| $scope.checkCubeForm = async function(stepIndex){ | |||
There was a problem hiding this comment.
"async" and "await" are the ES7 grammar，some lower version but is much popular browser such as ie10、chrome54 unsupported。
|
@ClausClaus has submitted another pr to fix this, close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allCubes field is redundant, and the corresponding authentication interface already exists on the back end.
https://issues.apache.org/jira/browse/KYLIN-4113