Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4173 cube list search can not work #846

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

luguosheng1314
Copy link

No description provided.

@asf-ci
Copy link

asf-ci commented Sep 19, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

Codecov Report

Merging #846 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #846      +/-   ##
===========================================
- Coverage     25.71%   25.7%   -0.02%     
+ Complexity     6125    6124       -1     
===========================================
  Files          1400    1400              
  Lines         83729   83729              
  Branches      11740   11740              
===========================================
- Hits          21531   21520      -11     
- Misses        60126   60139      +13     
+ Partials       2072    2070       -2
Impacted Files Coverage Δ Complexity Δ
...g/apache/kylin/rest/controller/CubeController.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ream/core/storage/columnar/ColumnarStoreCache.java 51.16% <0%> (-3.49%) 8% <0%> (ø)
.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java 63.84% <0%> (-2.31%) 0% <0%> (ø)
...eam/core/storage/columnar/DataSegmentFragment.java 57.37% <0%> (-1.64%) 17% <0%> (-1%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (-1.52%) 7% <0%> (ø)
...a/org/apache/kylin/dict/Number2BytesConverter.java 81.74% <0%> (-0.8%) 17% <0%> (-1%)
...org/apache/kylin/rest/util/QueryRequestLimits.java 40.47% <0%> (+4.76%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5867d6b...9dc5d74. Read the comment docs.

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit ac27da7 into apache:master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants