Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4168 fix sonar bug #859

Merged
merged 1 commit into from Oct 30, 2019
Merged

KYLIN-4168 fix sonar bug #859

merged 1 commit into from Oct 30, 2019

Conversation

zhangayqian
Copy link
Contributor

No description provided.

@asf-ci
Copy link

asf-ci commented Sep 26, 2019

Can one of the admins verify this patch?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5056

  • 6 of 21 (28.57%) changed or added relevant lines in 5 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+5.0e**-05%**) to 27.916%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/livy/LivyRestExecutor.java 0 1 0.0%
core-common/src/main/java/org/apache/kylin/common/QueryContext.java 0 3 0.0%
core-common/src/main/java/org/apache/kylin/common/KylinVersion.java 0 4 0.0%
cache/src/main/java/net/spy/memcached/RefinedKetamaNodeLocator.java 5 12 41.67%
Files with Coverage Reduction New Missed Lines %
core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java 1 81.08%
core-common/src/main/java/org/apache/kylin/common/KylinVersion.java 2 39.51%
core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java 2 80.23%
Totals Coverage Status
Change from base Build 5053: 5.0e-05%
Covered Lines: 23707
Relevant Lines: 84923

💛 - Coveralls

Copy link

@lshmouse lshmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nichunen Could you help to review it?

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e947dd8). Click here to learn what that means.
The diff coverage is 29.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #859   +/-   ##
=========================================
  Coverage          ?   25.43%           
  Complexity        ?     6104           
=========================================
  Files             ?     1411           
  Lines             ?    84993           
  Branches          ?    11916           
=========================================
  Hits              ?    21614           
  Misses            ?    61292           
  Partials          ?     2087
Impacted Files Coverage Δ Complexity Δ
...org/apache/kylin/common/livy/LivyRestExecutor.java 0% <0%> (ø) 0 <0> (?)
...ain/java/org/apache/kylin/common/QueryContext.java 0% <0%> (ø) 0 <0> (?)
.../main/java/org/apache/kylin/common/StorageURL.java 64.63% <0%> (ø) 20 <0> (?)
...va/net/spy/memcached/RefinedKetamaNodeLocator.java 25.8% <41.66%> (ø) 7 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e947dd8...20fc6ab. Read the comment docs.

@nichunen nichunen merged commit 42c6644 into apache:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants