Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYLIN-4168 Add two null judgements before using the object named input. #872

Merged
merged 1 commit into from Oct 16, 2019

Conversation

seraphlich
Copy link
Contributor

No description provided.

@asf-ci
Copy link

asf-ci commented Oct 8, 2019

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Oct 8, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #872 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #872      +/-   ##
============================================
- Coverage     25.47%   25.45%   -0.02%     
+ Complexity     6109     6107       -2     
============================================
  Files          1410     1410              
  Lines         84919    84919              
  Branches      11897    11897              
============================================
- Hits          21633    21620      -13     
- Misses        61204    61219      +15     
+ Partials       2082     2080       -2
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/kylin/common/KylinVersion.java 35.06% <0%> (ø) 11 <0> (ø) ⬇️
...he/kylin/dict/lookup/cache/RocksDBLookupTable.java 72.97% <0%> (-5.41%) 6% <0%> (-1%)
...ream/core/storage/columnar/ColumnarStoreCache.java 52.27% <0%> (-3.41%) 8% <0%> (ø)
...he/kylin/job/impl/threadpool/DefaultScheduler.java 74.41% <0%> (-2.33%) 12% <0%> (ø)
...eam/core/storage/columnar/DataSegmentFragment.java 57.37% <0%> (-1.64%) 17% <0%> (-1%)
...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java 69.6% <0%> (-1.52%) 7% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e64c23...4d66bd3. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 8, 2019

Pull Request Test Coverage Report for Build 5093

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 27.912%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core-common/src/main/java/org/apache/kylin/common/KylinVersion.java 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java 1 78.12%
Totals Coverage Status
Change from base Build 5075: -0.001%
Covered Lines: 23703
Relevant Lines: 84919

💛 - Coveralls

Copy link

@nichunen nichunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nichunen nichunen merged commit 4ded84b into apache:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants