Skip to content

Commit

Permalink
[KYUUBI #3847][FOLLOWUP] Add jdbc-shaded profile to support IDE debug
Browse files Browse the repository at this point in the history
### _Why are the changes needed?_
#3847

https://app.travis-ci.com/github/apache/incubator-kyuubi/jobs/590599391

```
SparkOperationSuite:
- get catalogs
- get schemas
- get tables
- get type info
- audit Kyuubi Hive JDBC connection common MetaData *** FAILED ***
  "...i Project Hive JDBC []Client" did not equal "...i Project Hive JDBC [Shaded ]Client" (SparkMetadataTests.scala:407)
  Analysis:
  "...i Project Hive JDBC []Client" -> "...i Project Hive JDBC [Shaded ]Client"
```

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #3955 from cxzl25/jdbc_shaded_followup.

Closes #3847

b229ebe [sychen] or
921b44b [sychen] travis -Pjdbc-shaded

Authored-by: sychen <sychen@ctrip.com>
Signed-off-by: Shaoyun Chen <csy@apache.org>
  • Loading branch information
cxzl25 committed Dec 9, 2022
1 parent a07d234 commit 1977588
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ install:
- ./build/mvn --version

before_script:
- export MVN_ARGS="-Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn"
- export MVN_ARGS="-Dmaven.javadoc.skip=true -Drat.skip=true -Dscalastyle.skip=true -Dspotless.check.skip -V -B -ntp -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Pjdbc-shaded"
- ./build/mvn clean install -DskipTests $MVN_ARGS


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,8 @@ trait SparkMetadataTests extends HiveJDBCTestHelper {

assert(metaData.allTablesAreSelectable)
assert(metaData.getClientInfoProperties.next)
assert(metaData.getDriverName === "Kyuubi Project Hive JDBC Shaded Client")
assert(metaData.getDriverName === "Kyuubi Project Hive JDBC Client" ||
metaData.getDriverName === "Kyuubi Project Hive JDBC Shaded Client")
assert(metaData.getDriverVersion === KYUUBI_VERSION)
assert(
metaData.getIdentifierQuoteString === " ",
Expand Down

0 comments on commit 1977588

Please sign in to comment.