Skip to content

Commit

Permalink
[KYUUBI #961] Fixed: opHanle's operation may not be release
Browse files Browse the repository at this point in the history
Align with `sessionManager.operationManager.closeOperation(operationHandle)` and remove first

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #975 from iodone/fix-opHanle-operation-not-release.

Closes #961

bd798e0 [odone] [KYUUBI #961] fixed: opHanle's operation may not be release

Authored-by: odone <odone.zhang@gmail.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit f1ae664)
Signed-off-by: Cheng Pan <chengpan@apache.org>
  • Loading branch information
iodone authored and pan3793 committed Aug 23, 2021
1 parent 6d59f4f commit 3cf8324
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ abstract class AbstractSession(
}

override def closeOperation(operationHandle: OperationHandle): Unit = withAcquireRelease() {
sessionManager.operationManager.closeOperation(operationHandle)
opHandleSet.remove(operationHandle)
sessionManager.operationManager.closeOperation(operationHandle)
}

override def getResultSetMetadata(
Expand Down

0 comments on commit 3cf8324

Please sign in to comment.