Merge pull request #10 from xiaoyuandajian/fix-#4057

Fix #4057
apache · Jan 13, 2023 · 55a0a43 · 55a0a43
2 parents 03fe8a8 + cb11935
commit 55a0a43
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/bin/docker-image-tool.sh b/bin/docker-image-tool.sh
@@ -227,8 +227,8 @@ Examples:
 EOF
 }
 
-# shellcheck disable=SC2199
-if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
+
+if [[ "$*" = *--help ]] || [[ "$*" = *-h ]]; then
   usage
   exit 0
 fi

diff --git a/bin/kyuubi b/bin/kyuubi
@@ -30,8 +30,8 @@ function usage() {
   echo "    -h | --help  - Show this help message"
 }
 
-# shellcheck disable=SC2199
-if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then
+
+if [[ "$*" = *--help ]] || [[ "$*" = *-h ]]; then
   usage
   exit 0
 fi

diff --git a/bin/kyuubi-logo b/bin/kyuubi-logo
@@ -18,15 +18,15 @@
 
 # Bugzilla 37848: When no TTY is available, don't output to console
 have_tty=0
-# shellcheck disable=SC2006
-if [[ "`tty`" != "not a tty" ]]; then
+
+if [[ "$(tty)" != "not a tty" ]]; then
     have_tty=1
 fi
 
 # Bugzilla 37848: When no TTY is available, don't output to console
 have_tty=0
-# shellcheck disable=SC2006
-if [[ "`tty`" != "not a tty" ]]; then
+
+if [[ "$(tty)" != "not a tty" ]]; then
     have_tty=1
 fi
 

diff --git a/bin/stop-application.sh b/bin/stop-application.sh
@@ -16,8 +16,8 @@
 # limitations under the License.
 #
 
-# shellcheck disable=SC2071
-if [[ $# < 1 ]] ; then
+
+if [[ $# -lt 1 ]] ; then
   echo "USAGE: $0 <application_id>"
   exit 1
 fi