Skip to content

Commit

Permalink
[# 6297] Package Spark SQL engine both Scala 2.12 and 2.13 Follow Up
Browse files Browse the repository at this point in the history
  • Loading branch information
PorterZhang2021 committed Apr 18, 2024
1 parent 8edcb00 commit 956ac49
Showing 1 changed file with 11 additions and 3 deletions.
14 changes: 11 additions & 3 deletions build/dist
Original file line number Diff line number Diff line change
Expand Up @@ -247,18 +247,25 @@ BUILD_COMMAND=("$MVN" clean install $MVN_DIST_OPT $@)
echo -e "\nBuilding with..."
# shellcheck disable=SC2145
echo -e "\$ ${BUILD_COMMAND[@]}\n"
# "${BUILD_COMMAND[@]}"

FILTERED_ARGS=()
# shellcheck disable=SC2045
for arg in "$@"; do
if [[ $arg != -Pscala* ]]; then
FILTERED_ARGS+=("$arg")
fi
done
# shellcheck disable=SC2050
if [ "$SCALA_VERSION" = "2.12" ]; then
EXTRA_SPARK_ENGINE_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.13 -pl :kyuubi-spark-sql-engine_2.13 -am)
EXTRA_SPARK_ENGINE_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT -Pscala-2.13 ${FILTERED_ARGS[@]} -pl :kyuubi-spark-sql-engine_2.13 -am)
else
EXTRA_SPARK_ENGINE_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT $@ -Pscala-2.12 -pl :kyuubi-spark-sql-engine_2.12 -am)
EXTRA_SPARK_ENGINE_BUILD_COMMAND=("$MVN" install $MVN_DIST_OPT -pl ${FILTERED_ARGS[@]} :kyuubi-spark-sql-engine_2.12 -am)
fi

# shellcheck disable=SC2145
echo -e "\$ ${EXTRA_SPARK_ENGINE_BUILD_COMMAND[@]}\n"

"${BUILD_COMMAND[@]}"
"${EXTRA_SPARK_ENGINE_BUILD_COMMAND[@]}"

# Make directories
Expand Down Expand Up @@ -307,6 +314,7 @@ done
cp "$KYUUBI_HOME/externals/kyuubi-flink-sql-engine/target/kyuubi-flink-sql-engine_${SCALA_VERSION}-${VERSION}.jar" "$DISTDIR/externals/engines/flink/"

# Copy spark engines
# shellcheck disable=SC2045
for scala_version in 2.12 2.13; do
cp "$KYUUBI_HOME/externals/kyuubi-spark-sql-engine/target/kyuubi-spark-sql-engine_${scala_version}-${VERSION}.jar" "$DISTDIR/externals/engines/spark/"
done
Expand Down

0 comments on commit 956ac49

Please sign in to comment.