Skip to content

Commit

Permalink
[KYUUBI #4108] [BUILD] Provide GitHub token to prevent 403 error
Browse files Browse the repository at this point in the history
### _Why are the changes needed?_

1. Provide GitHub token to prevent 403 error.

https://github.com/apache/kyuubi/actions/runs/3852055295/jobs/6563845498

```
    data: {
      message: "API rate limit exceeded for 65.52.35.0. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)",
      documentation_url: 'https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting'
    }
```

from [Github docs](https://docs.github.com/en/rest/overview/resources-in-the-rest-api?apiVersion=2022-11-28#rate-limits-for-requests-from-github-actions)

> When using GITHUB_TOKEN, the rate limit is 1,000 requests per hour per repository. For requests to resources that belong to an enterprise account on GitHub.com, GitHub Enterprise Cloud's rate limit applies, and the limit is 15,000 requests per hour per repository.

from [actions-setup-minikube docs](https://github.com/manusa/actions-setup-minikube#optional-input-parameters)

> GITHUB_TOKEN secret value to access GitHub REST API with an unlimited number of requests (optional but recommended)

2. bump up minikube from v1.25.2 to v1.28.0
3. bump up kubernetes from v1.23.3 to v1.25.4

### _How was this patch tested?_

Pass CI.

Closes #4108 from cfmcgrady/ga.

Closes #4108

d190711 [Fu Chen] fix ga

Authored-by: Fu Chen <cfmcgrady@gmail.com>
Signed-off-by: Fu Chen <cfmcgrady@gmail.com>
  • Loading branch information
cfmcgrady committed Jan 6, 2023
1 parent 88e9498 commit ae7265c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,9 @@ jobs:
- name: Setup Minikube
uses: manusa/actions-setup-minikube@v2.7.2
with:
minikube version: 'v1.25.2'
kubernetes version: 'v1.23.3'
minikube version: 'v1.28.0'
kubernetes version: 'v1.25.4'
github token: ${{ secrets.GITHUB_TOKEN }}
- name: kubectl pre-check
run: |
kubectl get serviceaccount
Expand Down

0 comments on commit ae7265c

Please sign in to comment.