Skip to content

Commit

Permalink
[KYUUBI #946] [TEST] Fix version test
Browse files Browse the repository at this point in the history
<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->
Fix #944

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #946 from pan3793/ver.

Closes #946

81f69c8 [Cheng Pan] Fix version test

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit c228ecc)
Signed-off-by: Cheng Pan <chengpan@apache.org>
  • Loading branch information
pan3793 committed Aug 18, 2021
1 parent 8e11244 commit bb4d1e8
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,6 @@ class UtilsSuite extends KyuubiFunSuite {
Utils.majorMinorVersion(HADOOP_COMPILE_VERSION)._1)
assert(Utils.minorVersion(KYUUBI_VERSION) ===
Utils.majorMinorVersion(KYUUBI_VERSION)._2)
assert(Utils.shortVersion(KYUUBI_VERSION) ===
KYUUBI_VERSION.stripSuffix("-SNAPSHOT"))
intercept[IllegalArgumentException](Utils.shortVersion("-" + KYUUBI_VERSION))
intercept[IllegalArgumentException](Utils.majorMinorVersion("-" + KYUUBI_VERSION))
}
Expand Down

0 comments on commit bb4d1e8

Please sign in to comment.