typo

apache · Feb 17, 2023 · c846148 · c846148
1 parent 839e713
commit c846148
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 10 deletions.
diff --git a/docs/deployment/settings.md b/docs/deployment/settings.md
@@ -457,7 +457,7 @@ You can configure the Kyuubi properties in `$KYUUBI_HOME/conf/kyuubi-defaults.co
 | kyuubi.server.limit.connections.per.ipaddress            | &lt;undefined&gt; | Maximum kyuubi server connections per ipaddress. Any user exceeding this limit will not be allowed to connect.                                                                                                                                 | int    | 1.6.0 |
 | kyuubi.server.limit.connections.per.user                 | &lt;undefined&gt; | Maximum kyuubi server connections per user. Any user exceeding this limit will not be allowed to connect.                                                                                                                                      | int    | 1.6.0 |
 | kyuubi.server.limit.connections.per.user.ipaddress       | &lt;undefined&gt; | Maximum kyuubi server connections per user:ipaddress combination. Any user-ipaddress exceeding this limit will not be allowed to connect.                                                                                                      | int    | 1.6.0 |
-| kyuubi.server.limit.connections.user.unlimited.list                         || The maximin connections of the user in the white list will not be limited.                                                                                                                                                                     | seq    | 1.7.0 |
+| kyuubi.server.limit.connections.user.unlimited.list                         || The maximum connections of the user in the white list will not be limited.                                                                                                                                                                     | seq    | 1.7.0 |
 | kyuubi.server.name                                       | &lt;undefined&gt; | The name of Kyuubi Server.                                                                                                                                                                                                                     | string | 1.5.0 |
 | kyuubi.server.redaction.regex                            | &lt;undefined&gt; | Regex to decide which Kyuubi contain sensitive information. When this regex matches a property key or value, the value is redacted from the various logs.                                                                                              || 1.6.0 |
 

diff --git a/docs/tools/kyuubi-admin.rst b/docs/tools/kyuubi-admin.rst
@@ -72,7 +72,7 @@ Usage: ``bin/kyuubi-admin refresh config [options] [<configType>]``
    * - userDefaultsConf
      - The user defaults configs with key in format in the form of `___{username}___.{config key}` from default property file.
    * - unlimitedUsers
-     - The users without maximin connections limitation.
+     - The users without maximum connections limitation.
 
 .. _list_engine:
 

diff --git a/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala b/kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
@@ -2333,7 +2333,7 @@ object KyuubiConf {
 
   val SERVER_LIMIT_CONNECTIONS_USER_UNLIMITED_LIST: ConfigEntry[Seq[String]] =
     buildConf("kyuubi.server.limit.connections.user.unlimited.list")
-      .doc("The maximin connections of the user in the white list will not be limited.")
+      .doc("The maximum connections of the user in the white list will not be limited.")
       .version("1.7.0")
       .serverOnly
       .stringConf

diff --git a/kyuubi-ctl/src/test/scala/org/apache/kyuubi/ctl/AdminControlCliArgumentsSuite.scala b/kyuubi-ctl/src/test/scala/org/apache/kyuubi/ctl/AdminControlCliArgumentsSuite.scala
@@ -19,7 +19,6 @@ package org.apache.kyuubi.ctl
 
 import org.apache.kyuubi.{KYUUBI_VERSION, KyuubiFunSuite}
 import org.apache.kyuubi.ctl.cli.AdminControlCliArguments
-import org.apache.kyuubi.ctl.cmd.refresh.RefreshConfigCommandConfigType
 import org.apache.kyuubi.ctl.cmd.refresh.RefreshConfigCommandConfigType._
 import org.apache.kyuubi.ctl.opt.{ControlAction, ControlObject}
 
@@ -64,8 +63,7 @@ class AdminControlCliArgumentsSuite extends KyuubiFunSuite with TestPrematureExi
     val opArgs = new AdminControlCliArguments(args)
     assert(opArgs.cliConfig.action === ControlAction.REFRESH)
     assert(opArgs.cliConfig.resource === ControlObject.CONFIG)
-    assert(
-      opArgs.cliConfig.adminConfigOpts.configType === RefreshConfigCommandConfigType.HADOOP_CONF)
+    assert(opArgs.cliConfig.adminConfigOpts.configType === HADOOP_CONF)
 
     args = Array(
       "refresh",
@@ -74,7 +72,7 @@ class AdminControlCliArgumentsSuite extends KyuubiFunSuite with TestPrematureExi
     val opArgs2 = new AdminControlCliArguments(args)
     assert(opArgs2.cliConfig.action === ControlAction.REFRESH)
     assert(opArgs2.cliConfig.resource === ControlObject.CONFIG)
-    assert(opArgs2.cliConfig.adminConfigOpts.configType === RefreshConfigCommandConfigType.USER_DEFAULTS_CONF)
+    assert(opArgs2.cliConfig.adminConfigOpts.configType === USER_DEFAULTS_CONF)
 
     args = Array(
       "refresh",
@@ -83,7 +81,7 @@ class AdminControlCliArgumentsSuite extends KyuubiFunSuite with TestPrematureExi
     val opArgs3 = new AdminControlCliArguments(args)
     assert(opArgs3.cliConfig.action === ControlAction.REFRESH)
     assert(opArgs3.cliConfig.resource === ControlObject.CONFIG)
-    assert(opArgs3.cliConfig.adminConfigOpts.configType === RefreshConfigCommandConfigType.UNLIMITED_USERS)
+    assert(opArgs3.cliConfig.adminConfigOpts.configType === UNLIMITED_USERS)
 
     args = Array(
       "refresh",

diff --git a/kyuubi-server/src/main/scala/org/apache/kyuubi/session/SessionLimiter.scala b/kyuubi-server/src/main/scala/org/apache/kyuubi/session/SessionLimiter.scala
@@ -119,7 +119,7 @@ class SessionLimiterWithUnlimitedUsersImpl(
     }
   }
 
-  def setUnlimitedUsers(unlimitedUsers: Set[String]): Unit = {
+  private[kyuubi] def setUnlimitedUsers(unlimitedUsers: Set[String]): Unit = {
     this.unlimitedUsers = unlimitedUsers
   }
 }

diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/AdminResourceSuite.scala
@@ -84,7 +84,7 @@ class AdminResourceSuite extends KyuubiFunSuite with RestFrontendTestHelper {
     assert(200 == response.getStatus)
   }
 
-  test("refresh unlimited users the kyuubi server") {
+  test("refresh unlimited users of the kyuubi server") {
     var response = webTarget.path("api/v1/admin/refresh/unlimited_users")
       .request()
       .post(null)