Skip to content

Commit

Permalink
[KYUUBI #959] Reduce EventLoggingService.onEvent time to one with com…
Browse files Browse the repository at this point in the history
…piled state

<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->

`setState`  has already call `EventLoggingService.onEvent`, so we don't need to call `EventLoggingService.onEvent` twice with compiled state .

```
  override def setState(newState: OperationState): Unit = {
    super.setState(newState)
    statementEvent.state = newState.toString
    statementEvent.stateTime = lastAccessTime
    EventLoggingService.onEvent(statementEvent)
  }
```

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #959 from ulysses-you/compile.

Closes #959

dc517a6 [ulysses-you] reduce on event

Authored-by: ulysses-you <ulyssesyou18@gmail.com>
Signed-off-by: ulysses-you <ulyssesyou18@gmail.com>
(cherry picked from commit a263ee9)
Signed-off-by: ulysses-you <ulyssesyou18@gmail.com>
  • Loading branch information
ulysses-you committed Aug 19, 2021
1 parent 19150ca commit e264123
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,8 @@ class ExecuteStatement(
spark.sparkContext.addSparkListener(operationListener)
result = spark.sql(statement)
// TODO( #921): COMPILED need consider eagerly executed commands
setState(OperationState.COMPILED)
statementEvent.queryExecution = result.queryExecution.toString()
EventLoggingService.onEvent(statementEvent)
setState(OperationState.COMPILED)
debug(result.queryExecution)
iter = new ArrayFetchIterator(result.collect())
setState(OperationState.FINISHED)
Expand Down

0 comments on commit e264123

Please sign in to comment.