Skip to content

Commit

Permalink
[KYUUBI #5626] [UI] Fix sytle linting violation in web ui
Browse files Browse the repository at this point in the history
### _Why are the changes needed?_

- To fix the style violation in web UI linting
`cd ./kyuubi-server/web-ui && pnpm run lint`

```
> kyuubi-ui1.9.0-SNAPSHOT lint /Users/bw/dev/kyuubi/kyuubi-server/web-ui
> eslint --ext .ts,vue --ignore-path .gitignore .

/Users/bw/dev/kyuubi/kyuubi-server/web-ui/src/test/unit/views/layout/aside.spec.ts
  37:25  error  Delete `⏎····`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

 ELIFECYCLE  Command failed with exit code 1.

```

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No.

Closes #5626 from bowenliang123/webui-lint-fix.

Closes #5626

b1c7d7b [Bowen Liang] web ui lint fix

Authored-by: Bowen Liang <liangbowen@gf.com.cn>
Signed-off-by: Cheng Pan <chengpan@apache.org>
  • Loading branch information
bowenliang123 authored and pan3793 committed Nov 6, 2023
1 parent fdacd23 commit eaee5e8
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,5 @@ test('mount component', () => {
plugins: [mockRouter, getStore()]
}
})
expect(wrapper.text())
.toContain(import.meta.env.VITE_APP_VERSION)
expect(wrapper.text()).toContain(import.meta.env.VITE_APP_VERSION)
})

0 comments on commit eaee5e8

Please sign in to comment.