[Improvement] Add a job or step for shell script style in Github Action

[yaooqinn]

Code of Conduct

• I agree to follow this project's Code of Conduct

Search before asking

• I have searched in the issues and found no similar issues.

What would you like to be improved?

shell script style consistency

How should we improve?

Maybe adding https://github.com/marketplace/actions/shell-linter in sytle.yaml is a good choice, or something else

Are you willing to submit PR?

• Yes I am willing to submit a PR!

[yaooqinn]

cc @RishiKumarRay, can you help with this?

[RishiKumarRay]

@yaooqinn yeah i can try , can you elaborate what needs to be done ? Please, i am not able to understand completely

[yaooqinn]

It is a style checker for code written in shell

For example, Kyuubi is mainly written in scala and java, so we already have style checkers for them, see https://github.com/apache/incubator-kyuubi/blob/master/.github/workflows/style.yml#L49

We need to introduce a consistent style/format for the existing and coming shell scripts, like bin/kyuubi.

[RishiKumarRay]

@yaooqinn ok, let me try this , assign me also the path of the scripts that needs to be checked is bin/kyuubi ? Or path where the scripts are present is different.

[yaooqinn]

You may check the repo yourself, this way is better for getting familiar with the codebase

[davidyuan1223]

hello,i want slove the problem.can i try?

[pan3793]

@xiaoyuandajian of course, feel free to send PR~

[davidyuan1223]

@pan3793 thanks

[davidyuan1223]

@pan3793 hello, this is my first pr, I try it in my fork project, I found there are something wrong, it's my problems or the shell script?

[davidyuan1223]

this is update script, I use shell-linter

[pan3793]

The shell-linter's doc say:

severity

Optional. Specify minimum severity of errors to consider [style, info, warning, error]. Default: style

So it's expected to report some style issue since we never use any shell linter to check that.

[davidyuan1223]

ok, thanks