Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Umbrella][KPIP-6] Introduce Trino frontend #3901

Closed
33 of 44 tasks
ulysses-you opened this issue Dec 5, 2022 · 6 comments
Closed
33 of 44 tasks

[Umbrella][KPIP-6] Introduce Trino frontend #3901

ulysses-you opened this issue Dec 5, 2022 · 6 comments
Labels
kind:umbrella This a umbrella ticket priority:major
Milestone
v1.7.0

Comments

@ulysses-you
Copy link
Contributor

ulysses-you commented Dec 5, 2022 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the proposal

The main goal is: Support trino-driver and trino-client connect to Kyuubi server

Proposal: https://docs.google.com/document/d/1EQBvyrYGo-m845Kg-6jN_0jhBEdDnZ1XMWjQYXnta-I/edit?usp=sharing

Task list

source

integration test

  • Add Trino-cli it
  • Add Trino-driver it
    • get catalogs
    • get schemas
    • get tables
    • get columns
    • get functions
    • get table types
    • get primary keys
    • get cross reference
    • get type info
    • set client info
    • execute query

docs

Are you willing to submit PR?

  • Yes. I can submit a PR independently to improve.
  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to improve.
  • No. I cannot submit a PR at this time.
@ulysses-you ulysses-you added kind:umbrella This a umbrella ticket priority:major labels Dec 5, 2022
@ulysses-you ulysses-you pinned this issue Dec 5, 2022
@ulysses-you
Copy link
Contributor Author

cc @iodone @yikf @yanghua @cxzl25 welcome to contribution

@yikf yikf mentioned this issue Dec 7, 2022
Closed
5 tasks
This was referenced Dec 8, 2022
Closed
Closed
Closed
@yaooqinn
Copy link
Member

yaooqinn commented Dec 9, 2022 •
edited
Loading

the subtask of Introduce antlr4 to parse query statement seems to extend the scope of this umbrella a lot, do we need a design doc for it?

or just handle the queries listed ahead that we need to parse

@ulysses-you
Copy link
Contributor Author

ulysses-you commented Dec 9, 2022 •
edited
Loading

According to It's scope, it is actuall not the subtask of this umbrella .. What I expected is a pr just for parsing Trino statement and only used for something like KyuubiTrinoSessionImpl, not a custom procedure for Kyuubi server and something else.

@yehere
Copy link
Contributor

yehere commented Dec 9, 2022

Is it necessary to supplement multi sql and test

@ulysses-you
Copy link
Contributor Author

@yehere it depends on the scope of your pr. in general, ut is necessary

This was referenced Dec 16, 2022
Closed
Closed
This was referenced Dec 30, 2022
Closed
Closed
ulysses-you pushed a commit that referenced this issue Jan 3, 2023
@yikf @ulysses-you
[KYUUBI #4053] Support GetTableTypes for trino fe
5e9ef7a 
### _Why are the changes needed?_

We intend to introduce Trino FE at #3901, This issue aims to support `GetTableTypes` as subtask.

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4054 from Yikf/getTableTypes.

Closes #4053

d702cf8 [Yikf] Support GetTableTypes for trino fe

Authored-by: Yikf <yikaifei1@gmail.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
This was referenced Jan 3, 2023
Closed
Closed
Closed
This was referenced Jan 11, 2023
Closed
Closed
ulysses-you pushed a commit that referenced this issue Jan 11, 2023
@yikf @ulysses-you
[KYUUBI #4140] Support GetColumns for Trino Fe
984eac1 
### _Why are the changes needed?_

Close #4140

This pr as a subtask of the #3901 to support GetColumns for Trino Fe.

### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4141 from Yikf/get-columns.

Closes #4140

6efb99c [Yikf] Support GetColumns for Trino Fe

Authored-by: Yikf <yikaifei1@gmail.com>
Signed-off-by: ulysses-you <ulyssesyou@apache.org>
@iodone iodone mentioned this issue Feb 2, 2023
Open
4 tasks
@yikf yikf mentioned this issue Feb 14, 2023
Closed
4 tasks
@yehere yehere mentioned this issue Feb 14, 2023
Closed
4 tasks
@iodone iodone mentioned this issue Feb 16, 2023
Closed
3 tasks
ulysses-you pushed a commit that referenced this issue Feb 20, 2023
@iodone @ulysses-you
[KYUUBI #4345] Add the doc of kyuubi trino server
dec4327 
#3901
### _Why are the changes needed?_

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4345 from iodone/trino-server-dock.

Closes #4345

6f8e314 [odone] add the doc of kyuubi trino server

Authored-by: odone <odone.zhang@gmail.com>
Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
ulysses-you pushed a commit that referenced this issue Feb 20, 2023
@iodone @ulysses-you
[KYUUBI #4345] Add the doc of kyuubi trino server
1b37e23 
#3901
### _Why are the changes needed?_

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4345 from iodone/trino-server-dock.

Closes #4345

6f8e314 [odone] add the doc of kyuubi trino server

Authored-by: odone <odone.zhang@gmail.com>
Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
(cherry picked from commit dec4327)
Signed-off-by: ulyssesyou <ulyssesyou@apache.org>
@ulysses-you ulysses-you added this to the v1.7.0 milestone Mar 8, 2023
@merrily01 merrily01 mentioned this issue Mar 30, 2023
Merged
@ulysses-you
Copy link
Contributor Author

closed since almost issues have been solved

@ulysses-you ulysses-you unpinned this issue Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:umbrella This a umbrella ticket priority:major
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
3 participants
@yaooqinn @ulysses-you @yehere