Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Introduce new config to force rewrite pod name #5654

Closed
3 tasks done
zwangsheng opened this issue Nov 9, 2023 · 1 comment
Closed
3 tasks done

[TASK][EASY] Introduce new config to force rewrite pod name #5654

zwangsheng opened this issue Nov 9, 2023 · 1 comment
Assignees
@zhaohehuhu
Labels
hacktoberfest

Comments

@zwangsheng
Copy link
Contributor

zwangsheng commented Nov 9, 2023 •
edited by pan3793
Loading

What's the level of this task?

EASY

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

  • Scala
  • Kyuubi Config Specification

Background and Goals

Now, Kyuubi respects Spark's behavior to generate the Driver Pod name and Executor Pod name prefix, it works well for standard workloads run on standard K8s. But if some third-party components use the pod name for other purposes, issues may occur on some edge cases, e.g. the very long but legal pod name.

Implementation steps

  1. Add new boolean configs named kyuubi.kubernetes.spark.forciblyRewriteDriverPodName.enabled and kyuubi.kubernetes.spark.forciblyRewriteExecutorPodNamePrefix.enabled.
  2. check this new config in SparkEngine file, to help force rewrite non reach MAX_LENGTH executor pod name prefix.

Additional context

Introduction of 2023 Kyuubi Code Contribution Program
@zwangsheng zwangsheng mentioned this issue Nov 9, 2023
Closed
3 tasks
@zhaohehuhu
Copy link
Contributor

@zwangsheng plz assign the task to me. Thanks.

@pan3793 pan3793 changed the title [TASK][EASY] Introduce new config to force rewrite executor pod name prefix [TASK][EASY] Introduce new config to force rewrite pod name Nov 9, 2023
@zhaohehuhu zhaohehuhu mentioned this issue Nov 11, 2023
Closed
3 tasks
pan3793 pushed a commit that referenced this issue Nov 13, 2023
@zhaohehuhu @pan3793
[KYUUBI #5654] Introduce new config to forcibly rewrite pod name
54a1d58 
### _Why are the changes needed?_
close #5654
This pr is to introduce a config for rewriting pod name, which can help users forcibly rewrite driver or executor pod name prefix.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request

### _Was this patch authored or co-authored using generative AI tooling?_

No.

Closes #5672 from zhaohehuhu/dev-1111.

Closes #5654

6a450e4 [hezhao2] introduce new config to force rewrite pod name

Authored-by: hezhao2 <hezhao2@cisco.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 0ce697e)
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaohehuhu zhaohehuhu

Labels
hacktoberfest
Projects
No open projects
2023 Kyuubi Code Contribution Program
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #5654] Introduce new config to forcibly rewrite pod name zhaohehuhu/incubator-kyuubi
2 participants
@zhaohehuhu @zwangsheng