Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK][EASY] Drop support for Spark 3.1 #6250

Closed
3 tasks done
pan3793 opened this issue Apr 3, 2024 · 4 comments
Closed
3 tasks done

[TASK][EASY] Drop support for Spark 3.1 #6250

pan3793 opened this issue Apr 3, 2024 · 4 comments
Assignees
@liuxiaocs7

Comments

@pan3793
Copy link
Member

pan3793 commented Apr 3, 2024

What's the level of this task?

EASY

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

  • Basic knowledge of Scala, Spark, GitHub Actions

Background and Goals

We have already deprecated the support for Spark 3.1 in 1.9.0(#6091), now, we'd like to drop the support for Spark 3.1 and obliterate the related code.

Implementation steps

  • Update code of kyuubi-spark-sql-engine
  • Update CI(GHA workflow)
  • Update docs (quick start, migration guide, etc.)

Additional context

Introduction of 2024H1 Kyuubi Code Contribution Program
@liuxiaocs7
Copy link
Member

Hi, @pan3793, i want to have a try, plz assign to me if possible.

@pan3793
Copy link
Member Author

pan3793 commented Apr 3, 2024

@liuxiaocs7 thanks, assigned.

@pan3793
Copy link
Member Author

pan3793 commented Apr 7, 2024

@liuxiaocs7 Do you have any progress on this task? An easy task typically costs a few hours to complete.

@liuxiaocs7
Copy link
Member

@liuxiaocs7 Do you have any progress on this task? An easy task typically costs a few hours to complete.

Hi, @pan3793, sorry for late, on the way.

@liuxiaocs7 liuxiaocs7 mentioned this issue Apr 7, 2024
Closed
4 tasks
@pan3793 pan3793 closed this as completed in 42c619a Apr 8, 2024
pan3793 added a commit to pan3793/kyuubi that referenced this issue Apr 9, 2024
@pan3793
[KYUUBI apache#6250][FOLLOWUP] Simplify code after dropping Spark 3.1
2b52de6
pan3793 added a commit that referenced this issue Apr 9, 2024
@pan3793
[KYUUBI #6250][FOLLOWUP] Simplify code after dropping Spark 3.1
563d005 
# 🔍 Description

As title, simplify code after dropping Spark 3.1.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GHA.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6277 from pan3793/6273-followup.

Closes #6250

2b52de6 [Cheng Pan] [KYUUBI #6250][FOLLOWUP] Simplify code after dropping Spark 3.1

Authored-by: Cheng Pan <chengpan@apache.org>
Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liuxiaocs7 liuxiaocs7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[KYUUBI #6250] Drop support for Spark 3.1 liuxiaocs7/kyuubi
2 participants
@pan3793 @liuxiaocs7