Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #109 add meaningful msg for front service port conflicts #111

Merged
merged 3 commits into from
Oct 25, 2018

Conversation

yaooqinn
Copy link
Member

No description provided.

@yaooqinn yaooqinn added this to the v0.4.0 milestone Oct 25, 2018
@yaooqinn yaooqinn self-assigned this Oct 25, 2018
@yaooqinn yaooqinn added this to To do in kyuubi via automation Oct 25, 2018
@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #111 into master will increase coverage by 1.74%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #111      +/-   ##
============================================
+ Coverage     66.48%   68.23%   +1.74%     
- Complexity      475      489      +14     
============================================
  Files            71       71              
  Lines          3390     3387       -3     
  Branches        487      485       -2     
============================================
+ Hits           2254     2311      +57     
+ Misses          878      820      -58     
+ Partials        258      256       -2
Impacted Files Coverage Δ Complexity Δ
...la/yaooqinn/kyuubi/spark/SparkSessionWithUGI.scala 74.74% <ø> (ø) 12 <0> (ø) ⬇️
...er/src/main/scala/yaooqinn/kyuubi/cli/Handle.scala 89.47% <0%> (+36.84%) 12 <0> (+6) ⬆️
...cala/yaooqinn/kyuubi/service/AbstractService.scala 76.66% <100%> (ø) 17 <0> (ø) ⬇️
...n/scala/yaooqinn/kyuubi/cli/HandleIdentifier.scala 65.78% <100%> (+1.5%) 12 <2> (-1) ⬇️
...scala/yaooqinn/kyuubi/server/FrontendService.scala 32.92% <100%> (+15.8%) 17 <0> (+9) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 202e1bd...c1a3955. Read the comment docs.

@yaooqinn yaooqinn merged commit 896eaaa into master Oct 25, 2018
kyuubi automation moved this from To do to Done Oct 25, 2018
@yaooqinn yaooqinn deleted the KYUUBI-109 branch October 25, 2018 03:56
@yaooqinn yaooqinn modified the milestone: v0.4.0 Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
kyuubi
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant