[KYUUBI #2008][FOLLOWUP] Support engine type and subdomain in kyuubi-ctl #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix
|
Codecov Report
@@ Coverage Diff @@
## master #2233 +/- ##
=========================================
Coverage 61.80% 61.81%
Complexity 69 69
=========================================
Files 331 331
Lines 16021 16021
Branches 2031 2031
=========================================
+ Hits 9902 9903 +1
+ Misses 5297 5295 -2
- Partials 822 823 +1
Continue to review full report at Codecov.
|
ulysses-you
approved these changes
Mar 28, 2022
|
thanks, merging to master/branch-1.5 |
ulysses-you
pushed a commit
that referenced
this pull request
Mar 28, 2022
### _Why are the changes needed?_ #2008 In version 1.5, the kyuubi version is added to the engine path registered to the znode, which makes the original list engine operation invalid. ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [x] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request Closes #2233 from cxzl25/KYUUBI-2008-FOLLOWUP. Closes #2008 78b8336 [sychen] Engine space with kyuubi version Authored-by: sychen <sychen@trip.com> Signed-off-by: ulysses-you <ulyssesyou@apache.org> (cherry picked from commit 015cbe5) Signed-off-by: ulysses-you <ulyssesyou@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
#2008
In version 1.5, the kyuubi version is added to the engine path registered to the znode, which makes the original list engine operation invalid.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request