Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUB-TASK][KPIP-4] Refine the batch info response #2812

Closed
wants to merge 2 commits into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Jun 2, 2022

Why are the changes needed?

Return more batch info for insight: user, name, createTime and endTime.

Support to list batches with filter conditions:

  • batchState
  • batchUser
  • createTime
  • endTime

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@turboFei turboFei force-pushed the return_more_info branch 2 times, most recently from c63c8ec to 3942dc2 Compare June 2, 2022 14:59
@turboFei turboFei changed the title Refine the batch info response [SUB-TASK][KPIP-4] Refine the batch info response Jun 2, 2022
@turboFei turboFei self-assigned this Jun 2, 2022
@turboFei turboFei added this to the v1.6.0 milestone Jun 2, 2022
@ulysses-you
Copy link
Contributor

As we are here, we can return the start time and end time in Batch. Includes get batch and list bathes interface.

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #2812 (972fe88) into master (aabc53e) will increase coverage by 0.09%.
The diff coverage is 95.60%.

@@             Coverage Diff              @@
##             master    #2812      +/-   ##
============================================
+ Coverage     62.99%   63.08%   +0.09%     
  Complexity      203      203              
============================================
  Files           481      481              
  Lines         21425    21491      +66     
  Branches       2843     2849       +6     
============================================
+ Hits          13497    13558      +61     
  Misses         6646     6646              
- Partials       1282     1287       +5     
Impacted Files Coverage Δ
...in/java/org/apache/kyuubi/client/BatchRestApi.java 93.10% <66.66%> (-6.90%) ⬇️
.../apache/kyuubi/server/api/v1/BatchesResource.scala 90.00% <95.45%> (+2.12%) ⬆️
...ala/org/apache/kyuubi/session/SessionManager.scala 86.61% <100.00%> (-0.19%) ⬇️
...ava/org/apache/kyuubi/client/api/v1/dto/Batch.java 84.78% <100.00%> (+8.11%) ⬆️
...e/kyuubi/server/statestore/SessionStateStore.scala 92.20% <100.00%> (+0.65%) ⬆️
...kyuubi/server/statestore/jdbc/JDBCStateStore.scala 88.93% <100.00%> (+0.30%) ⬆️
...g/apache/kyuubi/session/KyuubiSessionManager.scala 85.18% <100.00%> (-0.19%) ⬇️
.../org/apache/kyuubi/engine/jdbc/JdbcSQLEngine.scala 51.51% <0.00%> (-3.04%) ⬇️
...ache/kyuubi/operation/KyuubiOperationManager.scala 80.55% <0.00%> (-1.39%) ⬇️
.../org/apache/kyuubi/operation/KyuubiOperation.scala 69.33% <0.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aabc53e...972fe88. Read the comment docs.

@turboFei
Copy link
Member Author

turboFei commented Jun 3, 2022

As we are here, we can return the start time and end time in Batch. Includes get batch and list bathes interface.

sure

@ulysses-you
Copy link
Contributor

thanks, merging to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants