Refactor changelog #2839
Closed
Refactor changelog #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
reviewed
Jun 9, 2022
yaooqinn
reviewed
Jun 9, 2022
yaooqinn
reviewed
Jun 9, 2022
docs/changelog/v1.5.2-incubating.md
Outdated
| ## Changelog for Apache Kyuubi(Incubating) v1.5.2-incubating | ||
| - [Fix changelog nit](https://github.com/apache/incubator-kyuubi/commit/62b51aa3) | ||
| - [[KYUUBI #2746][INFRA][1.5] Improve NOTICE of binary release](https://github.com/apache/incubator-kyuubi/commit/35a4c488) | ||
| - [[KYUUBI-2422] Wrap close session with try-finally (#2836)](https://github.com/apache/incubator-kyuubi/commit/cbca761a) |
yaooqinn
reviewed
Jun 9, 2022
build/release/generate_changelog.sh
Outdated
| @@ -49,6 +49,6 @@ if [ "${LAST_RELEASE_TAG}" = "-h" ]; then | |||
| fi | |||
|
|
|||
| ## Add title for changelog doc. | |||
| echo "## Changelog for Apache Incubating Kyuubi $RELEASE_VERSION " > $CHANGELOG_PATH | |||
| echo "## Changelog for Apache Kyuubi(Incubating) $RELEASE_VERSION " > $CHANGELOG_PATH | |||
| ## Append well-formatted git log to changelog file. | |||
| git log --pretty="- [%s]($KYUUBI_GITHUB_COMMIT_URL%h) " $LAST_RELEASE_TAG..$CURRENT_RELEASE_TAG | grep -v "\[RELEASE\]" >> $CHANGELOG_PATH | |||
There was a problem hiding this comment.
let's remove the list-item marker -
|
@yaooqinn refactor the changelog |
|
you can break this PR into
|
yaooqinn
reviewed
Jun 9, 2022
build/release/generate_changelog.sh
Outdated
| git log --pretty="[%s]($KYUUBI_GITHUB_COMMIT_URL%h)%n" $LAST_RELEASE_TAG..$CURRENT_RELEASE_TAG | grep -v "\[RELEASE\]" >> $CHANGELOG_PATH |
@yaooqinn reverted the 1.5.2 changelog |
yaooqinn
reviewed
Jun 9, 2022
docs/changelog/v1.5.1-incubating.md
Outdated
| - [[KYUUBI #2134] Respect Spark bundled log4j in extension modules](https://github.com/apache/incubator-kyuubi/commit/30dc84b) | ||
| - [[KYUUBI #2150] [DOCS] Fix Getting Started With Kyuubi on Kubernetes](https://github.com/apache/incubator-kyuubi/commit/e232a83) | ||
| ## Changelog for Apache Kyuubi(Incubating) v1.5.1-incubating | ||
| [[KYUUBI #2354] Fix NPE in process builder log capture thread](https://github.com/apache/incubator-kyuubi/commit/5e76334e) |
There was a problem hiding this comment.
you should not remove 2 tailing spaces
|
LGTM except the pr desc |
|
@yaooqinn updated the description |
|
thanks, merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
refactor the changelog script to fix:
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request