Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KYUUBI-303][FOLLOWUP] Fix test #305

Closed
wants to merge 1 commit into from
Closed

[KYUUBI-303][FOLLOWUP] Fix test #305

wants to merge 1 commit into from

Conversation

ulysses-you
Copy link
Contributor

@ulysses-you ulysses-you commented Jan 26, 2021 •
edited by pull-request-badge bot
Loading

ulysses-you Closes #305 2 2 1 Target Issue Test Plan ❨?❩

Please add issue ID here?

Fixes #303

Why are the changes needed?

Fix test

Test Plan:

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible
  • Add screenshots for manual tests if appropriate
  • Run test locally before make a pull request

@ulysses-you ulysses-you mentioned this pull request Jan 26, 2021
Closed
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #305 (f67ca84) into master (666593c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #305   +/-   ##
=======================================
  Coverage   79.62%   79.62%           
=======================================
  Files          95       95           
  Lines        3401     3402    +1     
  Branches      399      399           
=======================================
+ Hits         2708     2709    +1     
  Misses        493      493           
  Partials      200      200
Impacted Files Coverage Δ
...la/org/apache/kyuubi/service/FrontendService.scala 97.60% <0.00%> (+<0.01%) ⬆️

@yaooqinn yaooqinn closed this in 05c64fe Jan 26, 2021
yaooqinn pushed a commit that referenced this pull request Jan 26, 2021
@ulysses-you @yaooqinn
[KYUUBI #303][FOLLOWUP] Fix test
45f6bb3 
fix #305
Squashed commit of the following:

commit f67ca84
Author: ulysses-you <ulyssesyou18@gmail.com>
Date:   Tue Jan 26 20:36:10 2021 +0800

    init
@yaooqinn yaooqinn added this to To do in kyuubi via automation Mar 4, 2021
@yaooqinn yaooqinn added the Test label Mar 4, 2021
@yaooqinn yaooqinn added this to the v1.1.0 milestone Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ulysses-you ulysses-you

Labels
None yet
Projects
No open projects
kyuubi
  
To do
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ulysses-you @yaooqinn