Fix engine log does not be overwrite #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
+ Coverage 80.57% 80.59% +0.02%
==========================================
Files 101 101
Lines 3701 3706 +5
Branches 453 452 -1
==========================================
+ Hits 2982 2987 +5
- Misses 484 485 +1
+ Partials 235 234 -1
Continue to review full report at Codecov.
|
pan3793
reviewed
Mar 9, 2021
| assert(file1.length() == 1) | ||
| Files.write(file1.toPath, "a".getBytes(), StandardOpenOption.APPEND) | ||
| assert(file1.length() == 2) | ||
| file1.setLastModified(System.currentTimeMillis() - Duration.ofDays(1).toMillis - 1000) |
There was a problem hiding this comment.
Should we explicitly set ENGINE_LOG_TIMEOUT rather than depends on default value?
There was a problem hiding this comment.
Yeah, use the config exsplicitly.
|
let's encourage people to fulfill these fields, it can help a lot to reduce the burden of the release process |
pan3793
reviewed
Mar 9, 2021
| @@ -65,7 +65,7 @@ trait ProcBuilder { | |||
| // Visible for test | |||
| private[kyuubi] var logCaptureThread: Thread = _ | |||
|
|
|||
| private lazy val engineLog: File = ProcBuilder.synchronized { | |||
| private[kyuubi] lazy val engineLog: File = ProcBuilder.synchronized { | |||
| val engineLogTimeout = conf.get(KyuubiConf.ENGINE_LOG_TIMEOUT) | |||
| val currentTime = System.currentTimeMillis() | |||
| val processLogPath = workingDir | |||
There was a problem hiding this comment.
Scala support SAM since 2.12, we can simplify below code as
val totalExistsFile = processLogPath.toFile.listFiles { (_, name) => name.startsWith(module) }
yaooqinn
approved these changes
Mar 9, 2021
ulysses-you
added a commit
that referenced
this pull request
Mar 9, 2021
 [](https://github.com/yaooqinn/kyuubi/pull/408)       [❨?❩](https://pullrequestbadge.com/?utm_medium=github&utm_source=yaooqinn&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT --> <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html 2. If the PR is related to an issue in https://github.com/yaooqinn/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'. 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'. --> ### _Why are the changes needed?_ <!-- Please clarify why the changes are needed. For instance, 1. If you add a feature, you can talk about the use case of it. 2. If you fix a bug, you can clarify why it is a bug. --> Bug fix, otherwise the engine log will always increase size with append mode. ### _How was this patch tested?_ Add new test. Closes #408 from ulysses-you/fix-engine-log-overwrite. 7e4fd1d [ulysses-you] simply code b8d92ee [ulysses-you] config 821891c [ulysses-you] init Authored-by: ulysses-you <ulyssesyou18@gmail.com> Signed-off-by: ulysses-you <ulyssesyou18@gmail.com> (cherry picked from commit 57ed76f) Signed-off-by: ulysses-you <ulyssesyou18@gmail.com>
|
thanks merging to branch-1.1 and master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Bug fix, otherwise the engine log will always increase size with append mode.
How was this patch tested?
Add new test.