Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KYUUBI #4078] [FOLLOWUP] fix shellcheck violations in scripts of /bin folder #4162

Closed
wants to merge 5 commits into from
Closed

[KYUUBI #4078] [FOLLOWUP] fix shellcheck violations in scripts of /bin folder #4162

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd39efd
fix-#4057 info:
davidyuan1223 Jan 13, 2023
86e4e1c
fix-#4057 info: modify the shellcheck errors file in ./bin
davidyuan1223 Jan 13, 2023
cb11935
Merge remote-tracking branch 'origin/fix-#4057' into fix-#4057
davidyuan1223 Jan 13, 2023
55a0a43
Merge pull request #10 from xiaoyuandajian/fix-#4057
davidyuan1223 Jan 13, 2023
c48ad38
remove the used blank lines
davidyuan1223 Mar 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bin/docker-image-tool.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ Examples:
EOF
}

# shellcheck disable=SC2199
if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the used blank line.

if [[ "$*" = *--help ]] || [[ "$*" = *-h ]]; then
usage
exit 0
fi
Expand Down
4 changes: 2 additions & 2 deletions bin/kyuubi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ function usage() {
echo " -h | --help - Show this help message"
}

# shellcheck disable=SC2199
if [[ "$@" = *--help ]] || [[ "$@" = *-h ]]; then

bowenliang123 marked this conversation as resolved.
Show resolved Hide resolved
if [[ "$*" = *--help ]] || [[ "$*" = *-h ]]; then
usage
exit 0
fi
Expand Down
8 changes: 4 additions & 4 deletions bin/kyuubi-logo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@

Copy link
Contributor

@bowenliang123 bowenliang123 Mar 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd be better to keep this blank line, separating the license block and the single line comment below. @davidyuan1223

# Bugzilla 37848: When no TTY is available, don't output to console
have_tty=0
# shellcheck disable=SC2006
if [[ "`tty`" != "not a tty" ]]; then

bowenliang123 marked this conversation as resolved.
Show resolved Hide resolved
if [[ "$(tty)" != "not a tty" ]]; then
have_tty=1
fi

# Bugzilla 37848: When no TTY is available, don't output to console
have_tty=0
# shellcheck disable=SC2006
if [[ "`tty`" != "not a tty" ]]; then

bowenliang123 marked this conversation as resolved.
Show resolved Hide resolved
if [[ "$(tty)" != "not a tty" ]]; then
have_tty=1
fi

Expand Down
4 changes: 2 additions & 2 deletions bin/stop-application.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
# limitations under the License.
#

# shellcheck disable=SC2071
if [[ $# < 1 ]] ; then

bowenliang123 marked this conversation as resolved.
Show resolved Hide resolved
if [[ $# -lt 1 ]] ; then
echo "USAGE: $0 <application_id>"
exit 1
fi
Expand Down