Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KYUUBI #4218] Prefer to use TableCatalog to load tables from session catalog #4219

Closed
wants to merge 4 commits into from
Closed

[KYUUBI #4218] Prefer to use TableCatalog to load tables from session catalog #4219

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7e4675
Using DB and table name when checking Delta table schema.
nousot-cloud-guy Jan 30, 2023
20337dc
Revert "Using DB and table name when checking Delta table schema."
nousot-cloud-guy Feb 4, 2023
a6d973a
Revert "[KYUUBI #1458] Delta lake table columns won't show up in DBea…
nousot-cloud-guy Feb 4, 2023
5698432
Reversing match order in getColumnsByCatalog.
nousot-cloud-guy Feb 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...park-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/shim/CatalogShim_v2_4.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ class CatalogShim_v2_4 extends SparkCatalogShim {
catalog.getTablesByName(identifiers).flatMap { t =>
val tableSchema =
if (t.provider.getOrElse("").equalsIgnoreCase("delta")) {
spark.table(t.identifier.table).schema
spark.table(f"${db}.${t.identifier.table}").schema
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use t.identifier.toString here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
spark.table(f"${db}.${t.identifier.table}").schema
spark.table(t.identifier.toString).schema

} else {
t.schema
}
Expand Down