New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce super-linter
action for linting JSON, XML, ENV files and bash_exec
#4295
Conversation
0d1563e
to
a539a31
Compare
b0ad057
to
1ad1a97
Compare
1ad1a97
to
d51fd39
Compare
Fix https://github.com/apache/kyuubi/actions/runs/4393204237/jobs/7693453883#step:4:29
|
The follow-up todos after this PR:
|
The licence header in JSON files like
|
b93d491
to
43787e2
Compare
Actually, the extended JSON format supports comments syntax. |
OK, used JSONC linter allowing comments in json files instead. |
super-linter
action for linting JSON, XML, ENV files and bash_exec
Codecov Report
@@ Coverage Diff @@
## master #4295 +/- ##
============================================
- Coverage 53.37% 53.34% -0.04%
Complexity 13 13
============================================
Files 571 571
Lines 31294 31294
Branches 4219 4219
============================================
- Hits 16703 16693 -10
- Misses 13012 13020 +8
- Partials 1579 1581 +2 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It's ready for review. Have a check when you have time. |
Thanks, merged to master. |
Why are the changes needed?
action/super-linter
with multiple linters, (https://github.com/marketplace/actions/super-linter)github/super-linter/slim
for faster image pullingbash_exec
for checking executable of bash scripts, with fixedtools/spark-block-cleaner/kubernetes/docker/entrypoint.sh
How was this patch tested?