Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _configurations in kerberos.rst #4362

Closed
wants to merge 1 commit into from
Closed

Add _configurations in kerberos.rst #4362

wants to merge 1 commit into from

Conversation

yikf
Copy link
Contributor

@yikf yikf commented Feb 17, 2023

Why are the changes needed?

Add _configurations in kerberos.rst

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@github-actions github-actions bot added the kind:documentation Documentation is a feature! label Feb 17, 2023
@yikf
Copy link
Contributor Author

yikf commented Feb 17, 2023

Before:
image
After:
image

@codecov-commenter
Copy link

Codecov Report

Merging #4362 (d8f1976) into master (ba1a868) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4362      +/-   ##
============================================
+ Coverage     53.63%   53.68%   +0.04%     
  Complexity       13       13              
============================================
  Files           562      562              
  Lines         30810    30810              
  Branches       4152     4152              
============================================
+ Hits          16526    16539      +13     
+ Misses        12729    12720       -9     
+ Partials       1555     1551       -4     
Impacted Files Coverage Δ
...ache/kyuubi/operation/KyuubiOperationManager.scala 80.00% <0.00%> (-2.67%) ⬇️
...g/apache/kyuubi/operation/BatchJobSubmission.scala 75.27% <0.00%> (-2.20%) ⬇️
...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala 79.01% <0.00%> (+0.61%) ⬆️
...apache/kyuubi/service/TBinaryFrontendService.scala 49.46% <0.00%> (+1.07%) ⬆️
...mon/src/main/scala/org/apache/kyuubi/Logging.scala 42.50% <0.00%> (+1.25%) ⬆️
...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala 60.60% <0.00%> (+1.51%) ⬆️
...ache/kyuubi/server/mysql/MySQLGenericPackets.scala 78.72% <0.00%> (+2.12%) ⬆️
.../apache/kyuubi/server/api/v1/BatchesResource.scala 71.62% <0.00%> (+2.79%) ⬆️
...ache/kyuubi/server/mysql/MySQLCommandHandler.scala 81.81% <0.00%> (+4.04%) ⬆️
.../kyuubi/server/mysql/constant/MySQLErrorCode.scala 20.00% <0.00%> (+6.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bowenliang123
Copy link
Contributor

Merged to master. But sorry to merged to 1.7 with an improper commit message (changes) in 021ab33. Can you help to fix that ? @pan3793

@pan3793 pan3793 added this to the v1.7.0 milestone Feb 18, 2023
pan3793 pushed a commit that referenced this pull request Feb 18, 2023
### _Why are the changes needed?_

Add `_configurations` in kerberos.rst

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4362 from Yikf/kerberos-doc-config.

Closes #4362

d8f1976 [Yikf] Add _configurations in kerberos.rst

Authored-by: Yikf <yikaifei@apache.org>
Signed-off-by: liangbowen <liangbowen@gf.com.cn>
@pan3793
Copy link
Member

pan3793 commented Feb 18, 2023

branch-1.7 is fixed, and 021ab33 was removed, please delete your local branch-1.7, then fetch remote and re-create local branch-1.7

SusurHe pushed a commit to SusurHe/incubator-kyuubi that referenced this pull request Feb 21, 2023
* 'master' of github.com:apache/kyuubi: (1557 commits)
  [KYUUBI apache#3951][FOLLOWUP] Audit the rest request params
  [KYUUBI apache#4377] Grant execute permission to release scripts
  [KYUUBI apache#4374] Release uploading should include kyuubi-spark-connector-hive
  [KYUUBI apache#4267] Show warning if SessionHandle is invalid
  [KYUUBI apache#4385] [DOCS] Refine release process
  [KYUUBI apache#4352] Support System.gc() with periodic GC interval
  [KYUUBI apache#4152][FOLLOWUP] LDAP configurations should be server-only
  [KYUUBI apache#4373] Using SVN_STAGING_REPO instead of SVN_STAGING_REPO in the release script to fix echo message
  [KYUUBI apache#4372] Support to return null value for OperationsResource rowset
  [KYUUBI apache#4371] Fix typo in `kyuubi_ecosystem.drawio`
  [KYUUBI apache#4216] Support to transfer client version for kyuubi hive jdbc and rest client sdk
  [KYUUBI apache#4345] Add the doc of kyuubi trino server
  [KYUUBI apache#3081][DOCS] Add Hudi connector doc in Trino
  [KYUUBI apache#4357] Bump Jersey from 2.38 to 2.39
  [KYUUBI apache#4338][FOLLOWUP] Fix K8s integration tests
  [KYUUBI apache#4326] [ARROW] Fix Spark session timezone format in arrow-based result format
  [KYUUBI apache#4360][FOLLOWUP] Get valid unlimited users from existing limiters instead of conf
  [KYUUBI apache#4362] Add `_configurations` in kerberos.rst
  [KYUUBI apache#4338] Bump Spark from 3.3.1 to 3.3.2
  [KYUUBI apache#4119][FOLLOWUP] Add app start time for batch api docs
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation Documentation is a feature!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants