Align the server/engine ExecuteStatement operation handle for Spark engine #4415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
operation_handle_align
branch
3 times, most recently
from
178bdc0
to
1cc0121
Compare
turboFei
force-pushed
the
operation_handle_align
branch
from
1cc0121
to
d3fbf05
Compare
Codecov Report
@@ Coverage Diff @@
## master #4415 +/- ##
============================================
+ Coverage 53.80% 53.82% +0.01%
Complexity 13 13
============================================
Files 564 564
Lines 30955 30968 +13
Branches 4170 4170
============================================
+ Hits 16656 16668 +12
- Misses 12739 12740 +1
Partials 1560 1560
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
reviewed
Feb 26, 2023
...park-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/SparkOperation.scala
Outdated
Show resolved
Hide resolved
pan3793
reviewed
Feb 26, 2023
...rk-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/ExecuteStatement.scala
Outdated
Show resolved
Hide resolved
pan3793
approved these changes
Feb 26, 2023
|
thanks, merged to master |
4 tasks
pan3793
pushed a commit
that referenced
this pull request
May 16, 2023
…for ExecuteScala, ExecutePython and PlanOnlyStatement ### _Why are the changes needed?_ As title. ### _How was this patch tested?_ - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4832 from turboFei/scala_python_handle. Closes #4415 a5a44df [fwang12] ut eaf7f00 [fwang12] ut c8d7a5c [fwang12] save Authored-by: fwang12 <fwang12@ebay.com> Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request