Fix variable usage issue in SessionManager#stop
#4462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4462 +/- ##
============================================
- Coverage 53.28% 53.22% -0.07%
Complexity 13 13
============================================
Files 569 569
Lines 31182 31182
Branches 4211 4211
============================================
- Hits 16615 16596 -19
- Misses 12991 13006 +15
- Partials 1576 1580 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pan3793
pushed a commit
that referenced
this pull request
Mar 7, 2023
### _Why are the changes needed?_ Fix variable usage issue in `SessionManager#stop` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4462 from Yikf/sessionmanager. Closes #4462 d4340d4 [Yikf] fix variable usage issue Authored-by: Yikf <yikaifei@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 8af07fa) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Merged to master/branch-1.6(v1.6.2)/1.7(v1.7.1) |
pan3793
pushed a commit
that referenced
this pull request
Mar 7, 2023
### _Why are the changes needed?_ Fix variable usage issue in `SessionManager#stop` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4462 from Yikf/sessionmanager. Closes #4462 d4340d4 [Yikf] fix variable usage issue Authored-by: Yikf <yikaifei@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 8af07fa) Signed-off-by: Cheng Pan <chengpan@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix variable usage issue in
SessionManager#stopHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request