Simplify and improve log for JDBCMetadataStore #4464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan3793
commented
Mar 6, 2023
| var connection: Connection = null | ||
| try { | ||
| connection = hikariDataSource.getConnection | ||
| connection.setAutoCommit(autoCommit) |
There was a problem hiding this comment.
autoCommit always is true in whole codebase
pan3793
requested review from
turboFei and
ulysses-you
and removed request for
turboFei
turboFei
approved these changes
Mar 7, 2023
pan3793
added a commit
that referenced
this pull request
Mar 7, 2023
### _Why are the changes needed?_ 1. enhance the log to include parameters for the prepared statement 2. remove redundant spaces from SQL 3. simplify code by using `JdbcUtils` ### _How was this patch tested?_ - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible - [ ] Add screenshots for manual tests if appropriate - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request Closes #4464 from pan3793/jdbc. Closes #4464 c3ae84f [Cheng Pan] Simplify and improve log for JDBCMetadataStore Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit 3310429) Signed-off-by: Cheng Pan <chengpan@apache.org>
|
Thanks, merged to master/1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
JdbcUtilsHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request