Enable REST frontend protocol by default #4483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind:documentation
bowenliang123
approved these changes
Mar 8, 2023
pan3793
commented
Mar 8, 2023
| startBatchChecker() | ||
| startInternal() | ||
| } catch { | ||
| case e: Exception => throw new KyuubiException(s"Cannot start $getName", e) | ||
| } | ||
| } | ||
| super.start() | ||
| info(s"Exposing REST endpoint at: ${server.getServerUri}") |
There was a problem hiding this comment.
Make output consistent
KyuubiTBinaryFrontendService: Service[KyuubiTBinaryFrontend] is started.
KyuubiTBinaryFrontendService: Starting and exposing JDBC connection at: jdbc:hive2://10.221.96.184:10009/
...
KyuubiRestFrontendService: Service[KyuubiRestFrontendService] is started.
KyuubiRestFrontendService: Exposing REST endpoint at: http://10.221.96.184:10099
There was a problem hiding this comment.
Possible to output the protocol as well?
There was a problem hiding this comment.
OK, currently it does not support SSL, so simply add http://
turboFei
approved these changes
Mar 8, 2023
cxzl25
approved these changes
Mar 8, 2023
pan3793
changed the title
|
Thanks all, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
REST frontend protocol was introduced in Kyuubi 1.4.0 #1349, more and more users are using REST in recent days, and to simplify the planned Web UI developments, I think we should enable the REST by default for master(1.8.0-SNAPSHOT).
I do not remove the "experiment" because we don't have strong confident to ensure the API stability in this time, I would like to defer it until the community has confident to mark it as stable.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request