Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trino typo #4491

Closed
wants to merge 1 commit into from
Closed

Conversation

Kiss736921
Copy link
Contributor

Why are the changes needed?

fix trino typos

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@pan3793 pan3793 changed the title fix trino typos Fix Trino typo Mar 10, 2023
@pan3793 pan3793 closed this in 454aed6 Mar 10, 2023
@pan3793
Copy link
Member

pan3793 commented Mar 10, 2023

@Kiss736921, thanks for contribution, merged to master/1.7

pan3793 pushed a commit that referenced this pull request Mar 10, 2023
### _Why are the changes needed?_
fix trino typos

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes #4491 from Kiss736921/fix_trino_typos.

Closes #4491

73eb20f [Alex] fix trino typos

Authored-by: Alex <zoulimin@kanzhun.com>
Signed-off-by: Cheng Pan <chengpan@apache.org>
(cherry picked from commit 454aed6)
Signed-off-by: Cheng Pan <chengpan@apache.org>
@pan3793 pan3793 added this to the v1.7.1 milestone Mar 10, 2023
@yaooqinn
Copy link
Member

Consider bind Alex zoulimin@kanzhun.com to you GitHub account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants