New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Add RowFilteringTestBase to improve the test coverage #4497
Conversation
BTW, can you take a look at the mvnd failure?
|
Codecov Report
@@ Coverage Diff @@
## master #4497 +/- ##
============================================
+ Coverage 53.20% 53.32% +0.12%
Complexity 13 13
============================================
Files 569 571 +2
Lines 31055 31285 +230
Branches 4194 4219 +25
============================================
+ Hits 16522 16682 +160
- Misses 12973 13024 +51
- Partials 1560 1579 +19 see 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Let's rerun the failed job this time. It seems mvnd daemon crashes due to memory usage or concurrency. Will consider increasing |
I tried serval times but consistently failed |
Yes, I noticed. But curiously the same job for other PR passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks, merged to master |
Why are the changes needed?
Add RowFilteringTestBase to improve the test coverage
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before make a pull request